Thread (16 messages) 16 messages, 4 authors, 2016-02-02

Re: [PATCH v2] mac80211: expose txq queue depth and size to drivers

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2016-01-27 14:27:02 

On Wed, 2016-01-27 at 15:26 +0100, Michal Kazior wrote:
quoted hunk ↗ jump to hunk
@@ -1294,6 +1298,8 @@ struct sk_buff *ieee80211_tx_dequeue(struct
ieee80211_hw *hw,
 	if (!skb)
 		goto out;
 
+	txqi->byte_cnt -= skb->len;
+
 	atomic_dec(&sdata->txqs_len[ac]);
This *looks* a bit worrying - you have an atomic dec for the # of
packets and a non-atomic one for the bytes.

You probably thought about it and I guess it's fine, but can you
explain it?

johannes
  



    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread

          
kprevious message in thread

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help