Re: [patch] mac80211: free sinfo on error path
From: Arend van Spriel <hidden>
Date: 2016-01-30 19:58:37
Also in:
kernel-janitors
On 30-01-16 15:39, Dan Carpenter wrote:
There is a missing kfree(sinfo) on error in sta_info_insert_finish().
Fixes: 5fe74014172d ('mac80211: avoid excessive stack usage in sta_info')
Signed-off-by: Dan Carpenter <redacted>Hi Dan, A fix for this has already been posted [1]. Although your 'Fixes:' tag is useful to have, I guess. Regards, Arend [1] http://mid.gmane.org/1454060944-11320-1-git-send-email-sudipm.mukherjee@gmail.com
quoted hunk ↗ jump to hunk
diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c index 6c198e6..1502efb 100644 --- a/net/mac80211/sta_info.c +++ b/net/mac80211/sta_info.c@@ -562,6 +562,7 @@ static int sta_info_insert_finish(struct sta_info *sta) __acquires(RCU) out_err: mutex_unlock(&local->sta_mtx); rcu_read_lock(); + kfree(sinfo); return err; } --To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html