Re: [PATCH v7] Add new mac80211 driver mwlwifi.

[resending as plain text....gmail...grrrh.]

On Fri, Dec 11, 2015 at 4:46 PM, Grant Grundler [off-list ref] wrote:

Sorry for the late response...just one point below

On Fri, Nov 20, 2015 at 3:22 AM, Johannes Berg [off-list ref]
wrote:

quoted

quoted

+#define MWL_DRV_NAME     KBUILD_MODNAME
+#define MWL_DRV_VERSION       "10.3.0.14"

versions like that are generally fairly useless since you don't update
them for every commit ...

When backporting to other kernel trees, it's extremely handy to have a
DRV_VERSION.

Checking if a particular kernel build has the expected driver version
trivial.  "mod_info" dumps the driver version for modules (which this will
usually be too).

And yes, it won't get updated for every commit only because other version
control might encapsulate those changes. Not every distro makes their build
versioning accessible to outsiders. So it's still helpful even if not
perfect.

Marvell can update this every time they resync with their own internal
versions.

cheers,
grant