Thread (7 messages) 7 messages, 3 authors, 2015-12-26

Re: [PATCH] enable setting MAC address for r8723au

From: Jes Sorensen <hidden>
Date: 2015-12-26 10:06:07

Daniel Lenski [off-list ref] writes:
On Wed, Dec 23, 2015 at 3:18 AM, Jes Sorensen [off-list ref] wrote:
quoted
Daniel Lenski [off-list ref] writes:
In addition, do *not* overwrite the eeprompriv.mac_addr - that struct is
a clean copy of the eeprom's data and should not be modified.

Please changed the dev entry and make sure they driver updates from
there instead.
I left that part alone (overwriting the eeprompriv.mac_addr) because
the existing code relies on it containing the correct *current* MAC
address in numerous places. But, fair enough.

This will require a much more complex patch, because there are
numerous functions which assume that eeprompriv.mac_addr is the
current address. (And some of these functions only receive the struct
rtw_adapter as an argument, rather than the complete netdev.)
quoted
Second, please CC me directly as the driver maintainer.

For longer term, please try out rtl8xxxu, hopefully we can
rm -rf drivers/staging/rtl8723au soon.
Woah, I didn't know that driver existed. I will take a look.
It's pretty new and should be available in 4.4. I'm still working on
it, so there may be a few rough edges.

Cheers,
Jes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help