Re: [PATCH V2 02/17] staging: wilc1000: send_config_pkt: add argument struct net_device
From: Greg KH <gregkh@linuxfoundation.org>
Date: 2015-11-04 20:44:52
On Fri, Oct 30, 2015 at 06:47:08PM +0900, Glen Lee wrote:
quoted hunk ↗ jump to hunk
This patch adds new argument struct net_device and pass dev to the function as well. Signed-off-by: Glen Lee <redacted> --- drivers/staging/wilc1000/coreconfigurator.c | 3 +- drivers/staging/wilc1000/coreconfigurator.h | 3 +- drivers/staging/wilc1000/host_interface.c | 196 +++++++++++++++++++++------- drivers/staging/wilc1000/wilc_wlan_if.h | 1 + 4 files changed, 156 insertions(+), 47 deletions(-)diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c index e10c6ff..3b4a950 100644 --- a/drivers/staging/wilc1000/coreconfigurator.c +++ b/drivers/staging/wilc1000/coreconfigurator.c@@ -586,7 +586,8 @@ s32 DeallocateAssocRespInfo(tstrConnectRespInfo *pstrConnectRespInfo) * @date 1 Mar 2012 * @version 1.0 */ -s32 send_config_pkt(u8 mode, struct wid *wids, u32 count, u32 drv) +s32 send_config_pkt(struct net_device *dev, u8 mode, struct wid *wids, + u32 count, u32 drv) { s32 counter = 0, ret = 0;
But you don't do anything with this new argument? And why struct net_device, why not your "local" structure instead? thanks, greg k-h