Re: [RESEND PATCH 07/10] net: wireless: iwlegacy: Remove unneeded variable ret
From: Sergei Shtylyov <hidden>
Date: 2015-10-28 13:35:18
Also in:
lkml, netdev
Hello. On 10/27/2015 10:02 PM, Punit Vara wrote:
quoted hunk ↗ jump to hunk
This patch is to the 3945-mac.c file that fixes up following warning by coccicheck: drivers/net/wireless/iwlegacy/3945-mac.c:247:5-8: Unneeded variable: "ret". Return "- EOPNOTSUPP" on line 249 Return -EOPNOTSUPP directly instead of return using ret Signed-off-by: Punit Vara <redacted> --- drivers/net/wireless/iwlegacy/3945-mac.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)diff --git a/drivers/net/wireless/iwlegacy/3945-mac.c b/drivers/net/wireless/iwlegacy/3945-mac.c index af1b3e6..ff4dc44 100644 --- a/drivers/net/wireless/iwlegacy/3945-mac.c +++ b/drivers/net/wireless/iwlegacy/3945-mac.c@@ -244,9 +244,7 @@ il3945_set_dynamic_key(struct il_priv *il, struct ieee80211_key_conf *keyconf, static int il3945_remove_static_key(struct il_priv *il) { - int ret = -EOPNOTSUPP; - - return ret; + return -EOPNOTSUPP; } static int@@ -529,7 +527,6 @@ il3945_tx_skb(struct il_priv *il, if (unlikely(tid >= MAX_TID_COUNT)) goto drop; } -
Unrelated white space change.
MBR, Sergei