Thread (3 messages) 3 messages, 2 authors, 2015-10-22

Re: [PATCH v3 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

flat view

From: Sergei Shtylyov <hidden>
Date: 2015-10-22 18:35:08
Also in: lkml, netdev

Hello.

On 10/22/2015 09:26 PM, Punit Vara wrote:
quoted hunk ↗ jump to hunk
This patch is to the ath5k/eeprom.c that fixes up warning caught by
coccicheck:

-Unneeded variable: "ret". Return "0" on line 1733

Remove unneccesary variable ret created to return zero.

Also removed empty line suggested by Sergei

Signed-off-by: Punit Vara <redacted>
---
  drivers/net/wireless/ath/ath5k/eeprom.c | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath5k/eeprom.c b/drivers/net/wireless/ath/ath5k/eeprom.c
index 94d34ee..0c82ea5 100644
--- a/drivers/net/wireless/ath/ath5k/eeprom.c
+++ b/drivers/net/wireless/ath/ath5k/eeprom.c
@@ -1707,8 +1707,7 @@ ath5k_eeprom_read_spur_chans(struct ath5k_hw *ah)
  	struct ath5k_eeprom_info *ee = &ah->ah_capabilities.cap_eeprom;
  	u32 offset;
  	u16 val;
-	int ret = 0, i;
-
   No, this one shouldn't have been removed. There should an empty line between the declarations and the statements.
quoted hunk ↗ jump to hunk
+	int i;
  	offset = AR5K_EEPROM_CTL(ee->ee_version) +
  				AR5K_EEPROM_N_CTLS(ee->ee_version);
MBR, Sergei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help