Re: [RFC 05/16] rtl8xxxu: Unbreak a user-visible string

Jakub Sitnicki [off-list ref] writes:

On Wed, Oct 21, 2015 at 03:46 AM CEST, Jes Sorensen
[off-list ref] wrote:

quoted

Jakub Sitnicki [off-list ref] writes:

quoted

Signed-off-by: Jakub Sitnicki <redacted>
---
 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c
index cfb18db..e892fde 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c

@@ -2002,8 +2002,8 @@ static int rtl8xxxu_read_efuse(struct rtl8xxxu_priv *priv)
 		/* We have 8 bits to indicate validity */
 		map_addr = offset * 8;
 		if (map_addr >= EFUSE_MAP_LEN_8723A) {
-			dev_warn(dev, "%s: Illegal map_addr (%04x), "
-				 "efuse corrupt!\n",
+			dev_warn(dev,
+				 "%s: Illegal map_addr (%04x), efuse corrupt!\n",

This would make the line longer than 80 characters - so no.

NAK

Oh, okay.  In my defense, Your Honor, Documentation/CodingStyle made me
do it ;-)

  [...] However, never break user-visible strings such as printk
  messages, because that breaks the ability to grep for them.

No worries, I am aware of that, I just don't like it so I break the
lines in reasonable places that still allow searching for them.

Cheers,
Jes