On Mon, 2015-06-01 at 23:49 +0530, Krishna Chaitanya wrote:

On Thu, Jan 30, 2014 at 11:48 PM, Krishna Chaitanya
[off-list ref] wrote:

quoted

On Thu, Jan 23, 2014 at 2:57 AM, Johannes Berg
[off-list ref] wrote:

quoted

On Wed, 2014-01-22 at 12:27 +0530, Chaitanya T K wrote:

quoted

+             if (sta->smps_mode == IEEE80211_SMPS_DYNAMIC &&
+                     minstrel_mcs_groups[i].streams > 1) {
+                     mi->tx_flags |= IEEE80211_TX_RC_USE_RTS_CTS;
+             } else if (sta->smps_mode == IEEE80211_SMPS_STATIC &&
+                     minstrel_mcs_groups[i].streams > 1) {

Your indentation is off inside the if statements. I'll have to wait for
nbd to review the patch itself, I guess.

Felix,

 Any comments other than the indentation? If no, will send in the
v2 with indentation fixed.

Was checking my old submissions. This was marked as "Not Applicable" in
patchwork.

Felix/Johannes,

Can you please explain to me the meaning of the status "Not Applicable"?

This patch is *ancient*, before we actually used patchwork properly ...

johannes