Re: [PATCH v2] adm8211: fix checkpatch error for trailing statements on next line
From: Kalle Valo <hidden>
Date: 2015-05-05 05:31:06
Also in:
lkml, netdev
Okash Khawaja [off-list ref] writes:
On Mon, May 04, 2015 at 03:42:04PM +0300, Kalle Valo wrote:quoted
Okash Khawaja [off-list ref] writes:quoted
This patch fixes the checkpatch.pl error: ERROR: trailing statements should be on next line More specifically, the fix has been applied to the four occurances of the error listed below. ERROR: trailing statements should be on next line #1101: FILE: drivers/net/wireless/adm8211.c:1101: + case 0x8: reg |= (0x1 << 14); ERROR: trailing statements should be on next line #1103: FILE: drivers/net/wireless/adm8211.c:1103: + case 0x16: reg |= (0x2 << 14); ERROR: trailing statements should be on next line #1105: FILE: drivers/net/wireless/adm8211.c:1105: + case 0x32: reg |= (0x3 << 14); ERROR: trailing statements should be on next line #1107: FILE: drivers/net/wireless/adm8211.c:1107: + default: reg |= (0x0 << 14); Signed-off-by: Okash Khawaja <redacted> --- drivers/net/wireless/adm8211.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-)The patch has incorrectly "staging:" prefix in the title, please fix that. "adm8211:" is enough, you don't need anything for drivers in drivers/net/wireless. -- Kalle ValoThanks Kalle for clarifying. I have removed "staging:" prefix and pasted the patch below. Signed-off-by: Okash Khawaja <redacted>
I cannot apply the mail directly as you added the old discussion to the commit log. Please just resend the whole patch with clean commit log. -- Kalle Valo