Re: [PATCH 06/13] wlcore: enable sleep during AP mode operation

On Wed, May 6, 2015 at 10:32 AM, Eliad Peller [off-list ref] wrote:

hi Yegor,

On Mon, May 4, 2015 at 12:16 PM, Yegor Yefremov
[off-list ref] wrote:

quoted

On Wed, Mar 25, 2015 at 2:45 PM, Eliad Peller [off-list ref] wrote:

quoted

On Wed, Mar 25, 2015 at 3:24 PM, Marc Kleine-Budde [off-list ref] wrote:

quoted

On 03/25/2015 01:58 PM, Eliad Peller wrote:

quoted

hi Marc,

On Wed, Mar 25, 2015 at 2:27 PM, Marc Kleine-Budde [off-list ref] wrote:

quoted

On 12/29/2014 07:24 AM, Eliad Peller wrote:

quoted

From: Kobi L <redacted>

Enable ELP authorization in AP mode and enable the use
of the wakeup bit in the ELP register.

Introduce AP role sleep configuration which is disabled
by default. When configured, it allows the AP to sleep
when ELP is authorized for it.

Signed-off-by: Kobi Leibovitch <redacted>
Signed-off-by: Arik Nemtsov <redacted>
Signed-off-by: Eliad Peller <redacted>

[...]


This patch requires a new firmware, loading of "wl18xx-conf.bin" from
[1] fails with:

quoted

wlcore: ERROR configuration binary file size is wrong, expected 1226 got 1221

thanks. seems you're right.

anyway, note that this file is not actual fw, but only the default
configuration params.
you can just delete it, and the driver will load just fine.
you can then recreate it with something like:
cat /sys/kernel/debug/ieee80211/phy0/wlcore/wl18xx/conf >
/lib/firmware/ti-connectivity/wl18xx-conf.bin

actually, i don't think it makes much sense to have this file in the
linux-firmware git at all.
i'll try handling it.

Thanks, there are more file with size of ~1k, are they optional, too?
What's the "error" message if these optional files are not present?

AFAIK, the other nvs files are basically required for proper operation.

quoted

From working with $CUSTOMERS I gained the impression, messages like
"error failed to load...." for optional file don't shine the best light
on Linux, a neutral "using default values" is far better.

i agree :)

Added Yaniv Machani in CC.

Any update on the wl18xx-conf.bin issue? This file is still in
linux-firmware repo.

thanks for the reminder :)

just sent a patch to fallback to default conf in case of invalid/outdated conf.

Great.

@Yaniv: but how to create a new conf with 1226 bytes for existing ini file?

Yegor