Re: [PATCH] wl18xx: fallback to default conf in case of invalid conf file

On Fri, May 8, 2015 at 4:12 PM, Kalle Valo [off-list ref] wrote:

Eliad Peller [off-list ref] writes:

quoted

If the wl18xx-conf.bin file is missing or invalid (e.g. due
to recent driver change), fallback to default configuration
instead of failing driver load.

Reported-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Eliad Peller <redacted>

This tells me that wl18xx is doing something wrong. The driver should
still work normally even if user space is old (and vice versa). Should
this configuration file (whatever that even is) have a version number in
file name to handle incompatible changes in a backwards compatible
manner?

the configuration file has a version number only in the header.
it is not backward compatible.

this is certainly not the optimal way to go, but since the driver will
now fallback to the default configuration, i guess it should be good
enough, and won't (completely) break current users.
(most users will use the default configuration anyway, so the conf
file is not that important)

Eliad.