Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

On Wed, Mar 11, 2015 at 3:21 PM, Javier Martinez Canillas
[off-list ref] wrote:

On Wed, Mar 11, 2015 at 2:17 PM, Arnd Bergmann [off-list ref] wrote:

quoted

On Wednesday 11 March 2015 14:07:11 Javier Martinez Canillas wrote:

quoted

Right now it seems that all boards in mainline with a WiLink6 part are
using internal clocks. So as a first step I think that adding an
optional refclock-frequency and tcxoclock-frequency properties should
be enough.

It would be good if the driver supports getting the refclock and
tcxoclock from an external provider in case a board gets these from
external clocks but that can be done as a followup if there are boards
in the future using that design.

But please bear in mind that I'm not familiar with the clock handling
in WiLink6 since the WiLink8 part used in the IGEP boards does not
need these clocks and I only looked at Luciano's previous patches and
the WiLink today driver today. So it would be good if Eliad can double
check my assumptions to see if those are correct.

sounds right. that's what i know as well.

quoted

Sounds good. I'd also be fine with not implementing the case for
external clocks in the code until we need (and can test) it, but
I think it should be specified in the binding from the start.

Agreed.

great. so i'll implement the internal clocks case only.

thanks,
Eliad.