Thread (2 messages) 2 messages, 2 authors, 2015-03-30

Re: [PATCH] mac80211: Fix misplaced return in AES-GMAC key setup

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2015-03-30 08:38:27

On Mon, 2015-03-23 at 15:41 +0200, Jouni Malinen wrote:
Commit 8ade538bf39b ("mac80111: Add BIP-GMAC-128 and BIP-GMAC-256
ciphers") had the success return in incorrect place before the
crypto_aead_setauthsize() call which practically ended up skipping that
call unconditionally.

The missing call did not actually change any functionality since
GMAC_MIC_LEN (16) is identical to the maxauthsize in gcm(aes) and as
such, the default value used for the authsize parameter.
Applied.

johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help