Re: [PATCH] mac80211: stop scan before connection

On Wed, 2015-03-18 at 11:36 +0200, Eliad Peller wrote:

On Tue, Mar 17, 2015 at 7:58 PM, Emmanuel Grumbach
[off-list ref] wrote:

quoted

From: David Spinadel <redacted>

Stop scan before authentication or association to make sure
that nothing interferes with connection flow.

this makes sense

quoted

Currently mac80211 defers RX auth and assoc packets (among other ones)
until after the scan is complete, so auth during scan is likely to fail
if scan took too much time.

but i don't think deferring the frame handling makes sense in case of
hw_scan (there was a similar case with BA request handling).
i should have such (one-liner) patch pending somewhere...

We did consider that, but ultimately I think it's not desirable.

The aggregation case is different, but during auth/assoc the relevant
frames cannot be buffered by the AP. So unless you have a hardware
mechanism that makes the device not continue the scan for say 30-50ms
after the auth/assoc req frame went out, the connection process will be
very unreliable.

So in a sense you could say deferring the handling doesn't make sense,
but I'd still argue you shouldn't start this process while you're in the
middle of scanning, hence this patch.

We may have to do more exclusions (e.g. don't start a scan while
authenticating or associating) here though, and ultimately not
*processing* the frames will be irrelevant as they shouldn't be coming
in anyway.

johannes