Thread (6 messages) 6 messages, 2 authors, 2015-02-26

Re: [PATCH v7 2/3] cfg80211: Add API to change the indoor regulatory setting

From: Luis R. Rodriguez <hidden>
Date: 2015-02-26 02:17:33

On Wed, Feb 25, 2015 at 04:47:03AM -0500, Ilan Peer wrote:
 	case NL80211_USER_REG_HINT_INDOOR:
-		return regulatory_hint_indoor_user();
+		is_indoor = !!info->attrs[NL80211_ATTR_REG_INDOOR];
+		if (info->attrs[NL80211_ATTR_SOCKET_OWNER])
+			owner_nlportid = info->snd_portid;
+
+		return regulatory_hint_indoor(is_indoor, owner_nlportid);
 	default:
 		return -EINVAL;
 	}
You are changing this so that this can only work when
NL80211_ATTR_REG_INDOOR is used however this should only
be true if the info->attrs[NL80211_ATTR_SOCKET_OWNER
was set as in the old days the usersapce API allowed
for NL80211_ATTR_REG_INDOOR to not be set. Don't
break old userspace.

Fix that, and it seems fine. While at it please explain
how / who send the userespace hint and that right now
we don't do anything with the country IE indoor / outdoor
flag.

 Luis
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help