Thread (8 messages) 8 messages, 4 authors, 2014-12-28

Re: [PATCH] bcma: fix three coding style issues, more than 80 characters per line

From: Arend van Spriel <hidden>
Date: 2014-12-28 15:01:13
Also in: lkml

On 12/28/14 15:02, Rafał Miłecki wrote:
On 28 December 2014 at 10:12, Sedat Dilek[off-list ref]  wrote:
quoted
On Sun, Dec 28, 2014 at 9:53 AM, Rafał Miłecki[off-list ref]  wrote:
quoted
On 28 December 2014 at 06:50, Sedat Dilek[off-list ref]  wrote:
quoted
On Sun, Dec 28, 2014 at 12:44 AM, Rafał Miłecki[off-list ref]  wrote:
quoted
On 27 December 2014 at 20:24, Oscar Forner Martinez
[off-list ref]  wrote:
quoted
Three lines with more than 80 characters per line have been split in several lines.

Signed-off-by: Oscar Forner Martinez<redacted>
Acked-by: Rafał Miłecki<zajec5@gmail.com>
As for the comment-line changes... 80+ chars are allowed for better readability.
So, please don't do that.
[ Checkpatch should not warn on this especially for comments. ]
We almost always split long comments into separated lines in the
kernel. What's different with this case?
1st it is not mandatory.

2nd it is more readable in one line.

-                       /* 4706 CC and PMU watchdogs are clocked at
1/4 of ALP clock */
+                       /* 4706 CC and PMU watchdogs are clocked at 1/4 of ALP
+                        * clock
+                        */

I agree with you when the comment would be longer.
So I guess there is some rule like
"Don't use 2 lines if there is 80 chars + one word"
? Where can I find such rules?
Personally, I don't like taking this sliding slope. Just stick to the 80 
characters rule and add a few words in the comment, eg:

			/* The BCM4706 ChipCommon and PMU watchdogs are
			 * clocked at one quarter of the ALP clock.
			 */

Regards,
Arend
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help