On Sun, Dec 21, 2014 at 6:25 PM, Johannes Berg
[off-list ref] wrote:

On Sun, 2014-12-21 at 17:27 +0200, Eliad Peller wrote:

quoted

On Sun, Dec 21, 2014 at 4:19 PM, Fred Chou [off-list ref] wrote:

quoted

On 21/12/2014 9:25 PM, Eliad Peller wrote:

quoted

dot11MulticastTransmittedFrameCount should be updated according
to the DA, which might be different from hdr1.

Shouldn't address 1 be used to determine whether the MPDU is multicast?
From Std-2012 definition of multicast: "When applied to a MAC protocol
data unit (MPDU), it is an MPDU with a group address in the Address 1
field."

good point. i guess it depends on the meaning of
dot11MulticastTransmittedFrameCount -
multicast frames sent by sta are not multicast frames per se (as they
are sent directly to the AP), but they are destined to multicast
group.

i tried understanding the meaning of this MIB from here (as i couldn't
find clear definition in the spec):
http://tools.cisco.com/Support/SNMP/do/BrowseOID.do?local=en&translate=Translate&objectInput=dot11MulticastTransmittedFrameCount

Yeah I can't find a good reference in the spec either - anyone want to
dig through the flow charts? :)

Btw, since this is ancient code from devicescape, it is possible that
they only cared about AP mode then - and there there's no difference
between the addresses.

makes sense.

quoted

where it seems to be similar (IIUC) to the way i interpreted it, but i
might got it wrong :)

I think you're probably right - however I wonder if we can stick the
code elsewhere (like subif xmit?) instead of introducing more
conditionals here?

well, we look for the tx status, so i think it makes sense to leave it here.

Eliad.