Thread (2 messages) flat view 2 messages, 2 authors, 2014-12-07

Re: [PATCH] mac80211: Supporting of IFLA_INFO_KIND rtnl attribute

From: Marcel Holtmann <marcel@holtmann.org>
Date: 2014-12-07 09:06:52
Also in: netdev

Hi Vadim,
quoted hunk
It allows to identify the wireless kind of device for
the user application, e.g.:

   # ip -d link

   1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT group default
       link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 promiscuity 0
   2: enp0s25: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc pfifo_fast state DOWN mode DEFAULT group default qlen 1000
       link/ether XX:XX:XX:XX:XX:XX brd ff:ff:ff:ff:ff:ff promiscuity 0
   3: wlp3s0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP mode DEFAULT group default qlen 1000
       link/ether XX:XX:XX:XX:XX:XX brd ff:ff:ff:ff:ff:ff promiscuity 0
       wireless
   4: wlp0s26u1u2: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
       link/ether XX:XX:XX:XX:XX:XX brd ff:ff:ff:ff:ff:ff promiscuity 0 
       wireless 

Signed-off-by: Vadim Kochan <redacted>
---
net/mac80211/iface.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c
index 653f5eb..b993c7d 100644
--- a/net/mac80211/iface.c
+++ b/net/mac80211/iface.c
@@ -18,6 +18,7 @@
#include <linux/rtnetlink.h>
#include <net/mac80211.h>
#include <net/ieee80211_radiotap.h>
+#include <net/rtnetlink.h>
#include "ieee80211_i.h"
#include "sta_info.h"
#include "debugfs_netdev.h"
@@ -1624,6 +1625,10 @@ static void ieee80211_assign_perm_addr(struct ieee80211_local *local,
	mutex_unlock(&local->iflist_mtx);
}

+static struct rtnl_link_ops wireless_link_ops __read_mostly = {
+	.kind = "wireless",
+};
+
I would prefer if we use "wlan" here. Same as what we use for DEVTYPE and RFKILL switches. Being consistent across the kernel helps a lot. Since other subsystems including Bluetooth might want to identify their netdev as well and "wireless" would be just too generic.

Regards

Marcel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help