Re: [PATCH] net: rfkill: gpio: Add default GPIO driver mappings for ACPI
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2014-10-27 11:24:29
Also in:
lkml
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2014-10-27 11:24:29
Also in:
lkml
On Mon, 2014-10-27 at 12:15 +0200, Mika Westerberg wrote:
The driver uses devm_gpiod_get_index(..., index) so that the index refers directly to the GpioIo resource under the ACPI device. The problem with this is that if the ordering changes we get wrong GPIOs. With ACPI 5.1 _DSD we can now use names instead to reference GPIOs analogous to Device Tree. However, we still have systems out there that do not provide _DSD at all. These systems must be supported as well. Luckily we now have acpi_dev_add_driver_gpios() that can be used to provide mappings for systems where _DSD is not provided and still take advantage of _DSD if it exists. This patch changes the driver to create default GPIO mappings if we are running on ACPI system. While there we can drop the indices completely and use devm_gpiod_get() with name instead. Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> --- Hi, This patch is based on top of linux-pm/device-properties [1] and following patch from Rafael [2]. Johannes, John, If you are happy with the patch, can you ACK it so that we can merge it with the rest of the device-properties patches. Thanks.
Acked-by: Johannes Berg <johannes@sipsolutions.net> Reviewed-by: Johannes Berg <johannes@sipsolutions.net> johannes