Thread (7 messages) 7 messages, 1 author, 2014-09-30
STALE4282d REVIEWED: 4 (0M)

[PATCH 4/6] brcmfmac: assure P2P discovery is disabled when setting P2P_DEVICE mac address

From: Arend van Spriel <hidden>
Date: 2014-09-30 08:23:24
Subsystem: networking drivers (wireless), the rest · Maintainers: Johannes Berg, Linus Torvalds

In order to provision the P2P_DEVICE mac address using p2p_da_override iovar
the discovery interface must be disabled. On some targets setting the mac
address failed so disable the discovery interface to be certain.

Reviewed-by: Hante Meuleman <redacted>
Reviewed-by: Franky (Zhenhui) Lin <redacted>
Reviewed-by: Daniel (Deognyoun) Kim <redacted>
Reviewed-by: Pieter-Paul Giesberts <redacted>
Signed-off-by: Arend van Spriel <redacted>
---
 drivers/net/wireless/brcm80211/brcmfmac/p2p.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/brcm80211/brcmfmac/p2p.c
index 1d78a91..d54c58a 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/p2p.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/p2p.c
@@ -440,8 +440,11 @@ static int brcmf_p2p_set_firmware(struct brcmf_if *ifp, u8 *p2p_mac)
 
 	/* In case of COB type, firmware has default mac address
 	 * After Initializing firmware, we have to set current mac address to
-	 * firmware for P2P device address
+	 * firmware for P2P device address. This must be done with discovery
+	 * disabled.
 	 */
+	brcmf_fil_iovar_int_set(ifp, "p2p_disc", 0);
+
 	ret = brcmf_fil_iovar_data_set(ifp, "p2p_da_override", p2p_mac,
 				       ETH_ALEN);
 	if (ret)
-- 
1.9.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help