Thread (7 messages) 7 messages, 2 authors, 2014-09-30

Re: [PATCH v2] ath: Add support for tracing

From: Sujith Manoharan <hidden>
Date: 2014-09-29 07:55:32

Kalle Valo wrote:
You mean ath_printk() & friends? But that doesn't require tracing code
to be in ath.ko as well, right? If I understood correctly, trace.c could
be under ath9k directory and the kconfig option could be
ATH9K_TRACEPOINTS.

I think it's just misleading and confusing for the user to call it
"Atheros wireless tracing" when it only affects ath9k. It's easier to
understand if each driver has it's own "tracing" kconfig option.
We have CONFIG_ATH_DEBUG, which is used by ath9k and ath9k_htc.
I think it is okay to have CONFIG_ATH_TRACEPOINTS, which can be
used by ath9k/ath9k_htc too.

The original motive of ath.ko was to have a common module with
debugging facilities that can be shared by Atheros drivers. But,
each driver has ended up reinventing things. Since it is mentioned
in the help text that ath9k is the only driver making use of
ATH_DEBUG/ATH_TRACEPOINTS, I don't think it is confusing.

Sujith
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help