Re: [PATCH] ath10k: fix wmi service bitmap debug
From: Michal Kazior <hidden>
Date: 2014-08-08 10:24:49
On 8 August 2014 12:11, Kalle Valo [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Michal Kazior [off-list ref] writes:quoted
The 10.x and main firmware branches have conflicting WMI service bitmap definitions. This also fixes WMI services parsing on big-endian hosts and changes debugfs output to be more human friendly. Signed-off-by: Michal Kazior <redacted>Based on Joe's suggestion, I'm planning to change the macro like below. Are you ok with that? It actually adds a new checkpatch warning but I'm going to ignore that for now: drivers/net/wireless/ath/ath10k/wmi.h:177: ERROR: Macros with complex values should be enclosed in parenthesisdiff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h index 109ea684f88f..e70836586756 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.h +++ b/drivers/net/wireless/ath/ath10k/wmi.h@@ -174,46 +174,48 @@ enum wmi_main_service { static inline char *wmi_service_name(int service_id) { -#define SVCSTR(x) { case x: return #x; } +#define SVCSTR(x) case x: return #x +
[...]
This was the checkpatch warning I originally fixed by using { .. } :-)
Anyway, I don't see a problem with the macro change you suggest.
Apparently we're doomed to have a checkpatch warning either way unless
we don't use a macro at all.
Michał