Re: [PATCH 1/6] lib / string_helpers: clean up test suite

From
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date
2014-07-03 09:35:19
Also in
lkml
Reply to
Andrew Morton, 2014-07-02
On Wed, 2014-07-02 at 14:54 -0700, Andrew Morton wrote:
On Wed,  2 Jul 2014 16:20:24 +0300 Andy Shevchenko [off-list ref] wrote:
[]
quoted
+	pr_err("Test '%s' failed: flags = %u\n", name, flags);
+
+	print_hex_dump(KERN_WARNING, "Input: ", DUMP_PREFIX_NONE, 16, 1,
+		       in, p, true);
+	print_hex_dump(KERN_WARNING, "Expected: ", DUMP_PREFIX_NONE, 16, 1,
+		       out_test, q_test, true);
+	print_hex_dump(KERN_WARNING, "Got: ", DUMP_PREFIX_NONE, 16, 1,
+		       out_real, q_real, true);
Seems strange to mix KERN_ERR and KERN_WARNING.  The code's always been
that way, but maybe it can be improved.
Will fix this.


-- 
Andy Shevchenko [off-list ref]
Intel Finland Oy
Thread (17 messages) 17 messages, 3 authors, last reply 2014-07-03
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help