Thread (1 message) 1 message, 1 author, 2014-07-01

Re: [PATCH 1/1] staging: rtl8723au: Remove unnecessary null test before kfree

From: Jes Sorensen <hidden>
Date: 2014-07-01 07:22:40
Also in: lkml

Fabian Frederick [off-list ref] writes:
quoted hunk
Fix checkpatch warning:
WARNING: kfree(NULL) is safe this check is probably not required

Cc: Larry Finger <redacted>
Cc: Jes Sorensen <redacted>
Cc: linux-wireless@vger.kernel.org
Signed-off-by: Fabian Frederick <redacted>
---
 drivers/staging/rtl8723au/core/rtw_cmd.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.c b/drivers/staging/rtl8723au/core/rtw_cmd.c
index 1696cb8..6af2b4a 100644
--- a/drivers/staging/rtl8723au/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723au/core/rtw_cmd.c
@@ -516,9 +516,7 @@ int rtw_joinbss_cmd23a(struct rtw_adapter *padapter,
 
 	psecnetwork = &psecuritypriv->sec_bss;
 	if (!psecnetwork) {
-		if (pcmd)
-			kfree(pcmd);
-
+		kfree(pcmd);
 		res = _FAIL;
 
 		RT_TRACE(_module_rtl871x_cmd_c_, _drv_err_,
Thanks, I applied this one to the rtl8723au tree.

Jes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help