Thread (1 message) 1 message, 1 author, 2014-07-01

Re: [PATCH 1/1] staging: rtl8723au: Another case of unnecessary null test before kfree

From: Jes Sorensen <hidden>
Date: 2014-07-01 07:22:42
Also in: lkml

Fabian Frederick [off-list ref] writes:
quoted hunk
Fix checkpatch warning:
WARNING: kfree(NULL) is safe this check is probably not required

Cc: Larry Finger <redacted>
Cc: Jes Sorensen <redacted>
Cc: linux-wireless@vger.kernel.org
Signed-off-by: Fabian Frederick <redacted>
---
 drivers/staging/rtl8723au/core/rtw_ap.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
index c8700b3..8714ae3 100644
--- a/drivers/staging/rtl8723au/core/rtw_ap.c
+++ b/drivers/staging/rtl8723au/core/rtw_ap.c
@@ -1270,8 +1270,7 @@ static void update_bcn_wps_ie(struct rtw_adapter *padapter)
 		pnetwork->IELength = wps_offset + (wps_ielen+2) + remainder_ielen;
 	}
 
-	if (pbackup_remainder_ie)
-		kfree(pbackup_remainder_ie);
+	kfree(pbackup_remainder_ie);
 }
 
 static void update_bcn_p2p_ie(struct rtw_adapter *padapter)
This one is no longer an issue due to other changes in my tree.

Cheers,
Jes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help