Re: [PATCH 2/2] rsi: fix memory leaks and error handling in rsi_91x_usb
From: Jonas Gorski <hidden>
Date: 2014-06-27 10:18:20
Also in:
lkml, netdev
From: Jonas Gorski <hidden>
Date: 2014-06-27 10:18:20
Also in:
lkml, netdev
On Fri, Jun 27, 2014 at 12:51 AM, Alexey Khoroshilov [off-list ref] wrote:
The patch fixes a couple of issues: - absence of deallocation of rsi_dev->rx_usb_urb[0] in the driver; - potential NULL pointer dereference because of lack of checks for memory allocation success in rsi_init_usb_interface(). By the way, it makes rsi_probe() returning error code instead of 1 and fixes comments regarding returning values. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov <redacted>
I count four different issues being fixed, so maybe split this into four patches? Regards Jonas