Re: [PATCH 0/10] use safer test on the result of find_first_zero_bit

From
Julia Lawall <hidden>
Date
2014-06-04 09:38:24
Also in
kernel-janitors, linux-fbdev, linux-rdma, linux-s390, linux-scsi, linux-sh, lkml, netdev
Reply to
Geert Uytterhoeven, 2014-06-04

On Wed, 4 Jun 2014, Geert Uytterhoeven wrote:
Hi Julia,

On Wed, Jun 4, 2014 at 11:07 AM, Julia Lawall [off-list ref] wrote:
quoted
Find_first_zero_bit considers BITS_PER_LONG bits at a time, and thus may
return a larger number than the maximum position argument if that position
is not a multiple of BITS_PER_LONG.
Shouldn't this be fixed in find_first_zero_bit() instead?
OK, I could do that as well.  Most of the callers currently test with >=.
Should they be left as is, or changed to use ==?

julia
Thread (11 messages) 11 messages, 3 authors, last reply 2014-06-04
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help