On Wed, 2014-06-04 at 07:13 +0200, Janusz Dziedzic wrote:

On 3 June 2014 21:58, Johannes Berg [off-list ref] wrote:

quoted

On Fri, 2014-05-30 at 11:44 +0200, Janusz Dziedzic wrote:

quoted

+     struct cfg80211_chan_def chandef;
      u16 len_rthdr;
      int hdrlen;

@@ -1721,9 +1721,9 @@ netdev_tx_t ieee80211_monitor_start_xmit(struct sk_buff *skb,
      }

      if (chanctx_conf)
-             chan = chanctx_conf->def.chan;
+             chandef = chanctx_conf->def;
      else if (!local->use_chanctx)
-             chan = local->_oper_chandef.chan;
+             chandef = local->_oper_chandef;

Why are you making a copy of the chandef - wouldn't a pointer work just
as well?

No special reason (chandef is quite small), should I change this to
pointer and send v2?

Yeah, I agree that it's pretty small, it just seemed odd, like you
wanted to locally modify it or something. I'd prefer a pointer here.

johannes