Thread (15 messages) 15 messages, 3 authors, 2014-06-29
STALE4402d REVIEWED: 1 (0M)

[PATCH 09/10] mac80211: make sure TDLS peer STA exists during setup

From: Arik Nemtsov <hidden>
Date: 2014-06-11 14:18:48
Subsystem: mac80211, the rest · Maintainers: Johannes Berg, Linus Torvalds

Make sure userspace added a TDLS peer station before invoking the
transmission of the first setup frame. This ensures packets to the peer
won't go through the AP path.

Signed-off-by: Arik Nemtsov <redacted>
Reviewed-by: Johannes Berg <redacted>
---
 net/mac80211/tdls.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)
diff --git a/net/mac80211/tdls.c b/net/mac80211/tdls.c
index 009601a..f100c12 100644
--- a/net/mac80211/tdls.c
+++ b/net/mac80211/tdls.c
@@ -332,6 +332,19 @@ ieee80211_tdls_mgmt_setup(struct wiphy *wiphy, struct net_device *dev,
 		goto exit;
 	}
 
+	/*
+	 * make sure we have a STA representing the peer so we drop or buffer
+	 * non-TDLS-setup frames to the peer. We can't send other packets
+	 * during setup through the AP path
+	 */
+	rcu_read_lock();
+	if (!sta_info_get(sdata, peer)) {
+		rcu_read_unlock();
+		ret = -ENOLINK;
+		goto exit;
+	}
+	rcu_read_unlock();
+
 	ieee80211_flush_queues(local, sdata);
 
 	ret = ieee80211_tdls_prep_mgmt_packet(wiphy, dev, peer, action_code,
-- 
1.9.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help