Re: [PATCH 6/11] net: wireless: Remove useless return variables
From: Dan Carpenter <hidden>
Date: 2014-05-31 20:24:14
Also in:
kernel-janitors, lkml, netdev
On Sat, May 31, 2014 at 10:14:06AM -0300, Peter Senna Tschudin wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c b/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c index b0fd807..57ecc05 100644 --- a/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c +++ b/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c@@ -1538,11 +1538,7 @@ static s8 wlc_user_txpwr_antport_to_rfport(struct brcms_phy *pi, uint chan, u32 band, u8 rate) { - s8 offset = 0; - - if (!pi->user_txpwr_at_rfport) - return offset; - return offset; + return 0; }
The original code looks buggy. I wonder what it was supposed to do? regards, dan carpenter