On Mon, 19 May 2014, Sergei Shtylyov wrote:

Hello.

On 19-05-2014 8:31, Julia Lawall wrote:

quoted

From: Julia Lawall <redacted>

quoted

Delete unnecessary local variable whose value is always 0 and that hides
the fact that the result is always 0.

quoted

A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)

quoted

// <smpl>
@r exists@
local idexpression ret;
expression e;
position p;
@@

-ret = 0;
... when != ret = e
return
- ret
+ 0
   ;
// </smpl>

quoted

Signed-off-by: Julia Lawall <redacted>

quoted

---
Alternatively, was an error code intended in the bad length case, as is
done in process_brxed_802_11_packet?

quoted

  drivers/net/wireless/libertas/rx.c |    7 ++-----
  1 file changed, 2 insertions(+), 5 deletions(-)

quoted

diff --git a/drivers/net/wireless/libertas/rx.c

b/drivers/net/wireless/libertas/rx.c
index c7366b0..807c5b8 100644

--- a/drivers/net/wireless/libertas/rx.c
+++ b/drivers/net/wireless/libertas/rx.c

[...]

quoted

@@ -154,10 +152,9 @@ int lbs_process_rxed_packet(struct lbs_private *priv,

struct sk_buff *skb)
  	else
  		netif_rx_ni(skb);

-	ret = 0;
  done:
-	lbs_deb_leave_args(LBS_DEB_RX, "ret %d", ret);
-	return ret;
+	lbs_deb_leave_args(LBS_DEB_RX, "ret %d", 0);

   Why not just "ret 0"?

Oops, I won't make any change here, because Dan Williams has proposed
another patch that makes the ret variable useful.

julia