Re: [PATCH v3.5 10/19] mac8011: slight optimization of addr compare
From: Ding Tianhong <hidden>
Date: 2014-01-07 03:41:46
Also in:
lkml, netdev
From: Ding Tianhong <hidden>
Date: 2014-01-07 03:41:46
Also in:
lkml, netdev
On 2014/1/6 23:11, Johannes Berg wrote:
On Thu, 2013-12-26 at 19:40 +0800, Ding Tianhong wrote:quoted
Use the possibly more efficient ether_addr_equal to instead of memcmp.This is a slow-path, I don't think that's really worth it. It kinda makes sense, but relies on the struct mac_address allocation for alignment and the fact that there are no other members in that struct, so it seems to me that this ought to also add some alignment attributes? johannes
Yes, I had to say that it is really a slight optimization.And I am sure the address in the struct is alignment, otherwise I have to use the ether_addr_equal_unaligned(). Regards Ding
-- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html