Thread (2 messages) 2 messages, 2 authors, 2014-01-06

Re: [PATCH 13/21] mac8011: slight optimization of addr compare

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2014-01-06 15:21:28
Also in: lkml, netdev

On Mon, 2013-12-23 at 13:10 +0800, Ding Tianhong wrote:
Use the recently added and possibly more efficient
ether_addr_equal_unaligned to instead of memcmp.
-				if (memcmp(local->hw.wiphy->addresses[i].addr,
-					   sdata->vif.addr, ETH_ALEN) == 0) {
+				if (ether_addr_equal_unaligned(local->hw.wiphy->addresses[i].addr, sdata->vif.addr)) {
This clearly should have some linebreaks.

This code also doesn't care all that much about efficiency, so not sure
it's worth it at all.

johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help