Thanks for your reply.
On 10/16 0:24, Joe Perches wrote:
On Tue, 2013-10-15 at 19:44 +0800, Kefeng Wang wrote:
quoted
Wrapper functions net_ratelimited_function() and net_XXX_ratelimited()
are called to simplify code.
[]
quoted
diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
[]
quoted
@@ -465,10 +465,8 @@ void br_fdb_update(struct net_bridge *br, struct net_bridge_port *source,
if (likely(fdb)) {
/* attempt to update an entry for a local interface */
if (unlikely(fdb->is_local)) {
- if (net_ratelimit())
- br_warn(br, "received packet on %s with "
- "own address as source address\n",
- source->dev->name);
+ net_ratelimited_function(br_warn, br, "received packet on %s "
+ "with own address as source address\n", source->dev->name);
Hello Kefeng.
When these types of lines are changed, please coalesce the
fragmented format pieces into a single string.
It makes grep a bit easier and 80 columns limits don't
apply to formats.
Got it, I will coalesce them, but 80 columns limits will be
broken.
I think using net_ratelimited_function is not particularly
clarifying here.
Maybe net_ratelimited_function should be removed instead
of its use sites expanded.
Perhaps adding macros like #define br_warn_ratelimited()
would be better.
yes, I found dev_emerg_ratelimited already exists. I should
use them and will add some similar mcaros.
This comment applies to the whole series.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
.