Thread (15 messages) 15 messages, 4 authors, 2013-10-09

Re: [PATCH] wcn36xx: mac80211 driver for Qualcomm WCN3660/WCN3680 hardware

From: Eugene Krasnikov <hidden>
Date: 2013-10-06 20:39:10

Hi Luis,

Warnings are valid! Thanx for pointing them. Will fix and resend the
patch togather with ur regdb patch+warning fix.

2013/10/6 Eugene Krasnikov [off-list ref]:
Hi Luis,

Thanx for the patch. Although there is a one small comment:
quoted
+static void wcn_reg_notifier(struct wiphy *wiphy,
+                            struct regulatory_request *request)
+{
Function should be called wcn36xx_reg_notifier not wcn_reg_notifier.
Could you please change that?

Also are you concerned about this warnings?
quoted
Nice! I test compiled with sparse enabled and got this:

mcgrof@chalten ~/wireless-testing (git::master)$ make C=1
M=drivers/net/wireless/ath/wcn36xx/
CHECK   drivers/net/wireless/ath/wcn36xx/main.c
CC [M]  drivers/net/wireless/ath/wcn36xx/main.o
CHECK   drivers/net/wireless/ath/wcn36xx/dxe.c
CC [M]  drivers/net/wireless/ath/wcn36xx/dxe.o
CHECK   drivers/net/wireless/ath/wcn36xx/txrx.c
CC [M]  drivers/net/wireless/ath/wcn36xx/txrx.o
CHECK   drivers/net/wireless/ath/wcn36xx/smd.c
/home/mcgrof/wireless-testing/arch/x86/include/asm/bitops.h:329:18: warning: invalid access past the end of 'caps' (4096 8)
/home/mcgrof/wireless-testing/arch/x86/include/asm/bitops.h:329:18: warning: invalid access past the end of 'caps' (512 8)
/home/mcgrof/wireless-testing/arch/x86/include/asm/bitops.h:329:18: warning: invalid access past the end of 'caps' (128 8)
/home/mcgrof/wireless-testing/arch/x86/include/asm/bitops.h:329:18: warning: invalid access past the end of 'caps' (8 8)
/home/mcgrof/wireless-testing/arch/x86/include/asm/bitops.h:329:18: warning: invalid access past the end of 'caps' (256 8)
/home/mcgrof/wireless-testing/arch/x86/include/asm/bitops.h:329:18: warning: invalid access past the end of 'caps' (4096 8)
What kind of config are you using to generate this warnings?


-- 
Best regards,
Eugene
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help