Re: [PATCH 4/8 V2] rtlwifi: rtl8192_common: Fix smatch errors and warnings in rtl8192c/dm_common.c

Hello.

On 09/16/2013 11:07 PM, Larry Finger wrote:

quoted

quoted

Smatch lists the following:
   CHECK   drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:551 rtl92c_dm_pwdb_monitor()
info: ignoring unreachable code.
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:551 rtl92c_dm_pwdb_monitor()
info: ignoring unreachable code.
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:870
rtl92c_dm_txpower_tracking_callback_thermalmeter() error: buffer overflow
'txpwr_level' 2 <= 2
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:870
rtl92c_dm_txpower_tracking_callback_thermalmeter() error: buffer overflow
'txpwr_level' 2 <= 2
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:882
rtl92c_dm_txpower_tracking_callback_thermalmeter() error: buffer overflow
'txpwr_level' 2 <= 2
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:883
rtl92c_dm_txpower_tracking_callback_thermalmeter() error: buffer overflow
'txpwr_level' 2 <= 2
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:891
rtl92c_dm_txpower_tracking_callback_thermalmeter() error: buffer overflow
'txpwr_level' 2 <= 2
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:892
rtl92c_dm_txpower_tracking_callback_thermalmeter() error: buffer overflow
'txpwr_level' 2 <= 2

quoted

quoted

The unreachable code message is fixed by commenting out the code that follows
a return.

quoted

    You've commented out the whole function body, where is the *return* you're
talking about?

The return is in the middle of the function body just after the variable
declarations. It does not show in the diff listing, but it is there. What
should I do?

    Just describe what you really did, I guess.

Larry

WBR, Sergei