Thread (32 messages) 32 messages, 3 authors, 2013-08-21

Re: [PATCH 09/16] wcn36xx: Add smd.c

From: Joe Perches <joe@perches.com>
Date: 2013-08-20 18:12:14

On Tue, 2013-08-20 at 19:41 +0200, Eugene Krasnikov wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
[]
+int wcn36xx_smd_load_nv(struct wcn36xx *wcn)
+{
[]
+		/* Add NV body itself */
+		/* Rework me */
+		memcpy(wcn->smd_buf + sizeof(msg_body),
+		       (void *)(&nv_d->table) + fm_offset,
+		       msg_body.nv_img_buffer_size);
Does this really do what you want?

Perhaps it should be:

		memcpy(wcn->smd_buf + sizeof(msg_body),
		       ((void *)&nv_d->table) + fm_offset,
		       msg_body.nv_img_buffer_size);


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help