Re: [rt2x00-users] [PATCH 3.11] rt2800: fix wrong TX power compensation
From: Paul Menzel <hidden>
Date: 2013-08-26 20:20:25
Am Montag, den 26.08.2013, 15:18 +0200 schrieb Stanislaw Gruszka:
We should not do temperature compensation on devices without EXTERNAL_TX_ALC bit set (called DynamicTxAgcControl on vendor driver). Such devices can have totally bogus TSSI parameters on the EEPROM, but still threaded by us as valid and result doing wrong TX power
• s,still threaded,are still treated, • … and results in wrong TX power calculations.
calculations. This fix inability to connect to AP on slightly longer distance on
• fixes
some Ralink chips/devices.
Could you please add which ones you have tested? Is there a bug report about this?
quoted hunk ↗ jump to hunk
Reported-and-tested-by: Fabien ADAM <redacted> Cc: stable@vger.kernel.org Signed-off-by: Stanislaw Gruszka <redacted> --- drivers/net/wireless/rt2x00/rt2800lib.c | 7 +++++++ 1 file changed, 7 insertions(+) John, If possible this should go to 3.11, -next & cc -stable is also fine as ususal. Note that in -next version of the patch rt2x00_eeprom_read() should be changed to rt2800_eeprom_read() do to commit 3e38d3daf881a78ac13e93504a8ac5777040797ediff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c index 1f80ea5..a0119d3 100644 --- a/drivers/net/wireless/rt2x00/rt2800lib.c +++ b/drivers/net/wireless/rt2x00/rt2800lib.c@@ -2790,6 +2790,13 @@ static int rt2800_get_gain_calibration_delta(struct rt2x00_dev *rt2x00dev) int i; /* + * First check if temperature compensation is supported. + */ + rt2x00_eeprom_read(rt2x00dev, EEPROM_NIC_CONF1, &eeprom); + if (!rt2x00_get_field16(eeprom, EEPROM_NIC_CONF1_EXTERNAL_TX_ALC)) + return 0; + + /* * Read TSSI boundaries for temperature compensation from * the EEPROM. *
With the improvements to the commit message, Acked-by: Paul Menzel <redacted> Thanks, Paul
Attachments
- signature.asc [application/pgp-signature] 198 bytes