Re: [PATCH 3/4] ath10k: implement 802.3 SNAP rx decap type A-MSDU handling
From: Kalle Valo <hidden>
Date: 2013-08-12 14:56:05
Michal Kazior [off-list ref] writes:
This enables driver to rx another decapped a-msdu frames. It should possibly help with throughputs in some cases and reduce (or eliminate) number of messages like this: ath10k: error processing msdus -524 Signed-off-by: Michal Kazior <redacted>
[...]
quoted hunk ↗ jump to hunk
@@ -659,6 +658,15 @@ static int ath10k_htt_rx_amsdu(struct ath10k_htt *htt, decap_hdr += roundup(crypto_len, 4); } + if (fmt == RX_MSDU_DECAP_8023_SNAP_LLC) { + /* SNAP 802.3 consists of: + * [dst:6][src:6][len:2][dsap:1][ssap:1][ctl:1][snap:5] + * [data][fcs:4]. + * + * Since this overlaps with A-MSDU header (da, sa, len) + * there's nothing extra to do. */ + }
This block doesn't have any code, is that on purpose? Most likely a
static checker finds this later and we need to remove it.
If your idea is to document the LLC case (which is very good!) it's
better to do everything inside a comment, for example like this:
/* When fmt == RX_MSDU_DECAP_8023_SNAP_LLC:
*
* SNAP 802.3 consists of:
* [dst:6][src:6][len:2][dsap:1][ssap:1][ctl:1][snap:5]
* [data][fcs:4].
*
* Since this overlaps with A-MSDU header (da, sa, len)
* there's nothing extra to do. */
--
Kalle Valo