Re: [PATCH] ath5k: make use of the new rate control API

HI,

This patch is missing changes in the tx status path. At tx completion,
info->status.rates needs to be filled with the contents of bf->rates
before filling in retry counts.

Thats right, I will fix this in V2.

quoted

+	txrate.count = bf->rates[0].count;
+
	ret = ah->ah_setup_tx_desc(ah, ds, pktlen,
		ieee80211_get_hdrlen_from_skb(skb), padsize,
		get_hw_packet_type(skb),
		(ah->ah_txpower.txp_requested * 2),
		hw_rate,
-		info->control.rates[0].count, keyidx, ah->ah_tx_ant, flags,
+		txrate.count, keyidx, ah->ah_tx_ant, flags,
		cts_rate, duration);
	if (ret)
		goto err_unmap;

The txrate variable is pointless, you only use txrate.count where you
could also just use bf->rates[0].count directly.

I will remove this variable.

Thx for you review.

Thomas

- Felix
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html