2013.03.27. 21:38 keltezéssel, Gertjan van Wingerde írta:

Sent from my iPad

On 27 mrt. 2013, at 19:25, John Crispin [off-list ref] wrote:

quoted

On 27/03/13 18:17, John W. Linville wrote:

quoted

On Thu, Mar 21, 2013 at 08:35:34AM +0100, John Crispin wrote:

quoted

quoted

quoted

Fix up the dependencies to make the driver actually compile on Ralink WiSoC.

Signed-off-by: John Crispin<redacted>

I don't think this is a proper way to handle this. rt2x00pci.c was only meant to be used for PCI devices; introducing the use of CONFIG_PCI in that file doesn't seem appropriate to me.

Unfortunately I am away from my home computer, so I can't look at this properly until the weekend.

Indeed not the cleanest patch ... after changing the config symbols
I realized that that is not enough to make the driver actually work

It turns out that inside openwrt the compat-wireless package sets
CONFIG_RT2800PCI=m to make the driver build and then applies the
#ifdef'ery to rt2880pci.c

I will try to find the time today or tomorrow to have a closer look at this

Any more word on this?

Gabor posted a series as RFC that would fix this properly ->

http://rt2x00.serialmonkey.com/pipermail/users_rt2x00.serialmonkey.com/2013-March/005837.html

Yeah, and that series looks good. Unfortunately, it is too intrusive to still apply for 3.9.

John L., could we get in a scheme where we apply John C.'s patch for 3.9 and then use Gabor's series for 3.10?
Don't know how that works with making sure that this patch is reverted for 3.10.

Can you coordinate, or should I help you with this?

Sorry for the late reply. I have sent a less intrusive version of that RFC
patch-set, as an alternative solution.

-Gabor