Re: [PATCH] ath9k_htc: Fix skb leaks
From: Sujith Manoharan <hidden>
Date: 2013-01-02 04:39:26
Also in:
lkml, netdev, stable
Larry Finger wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/wireless/ath/ath9k/htc_hst.c b/drivers/net/wireless/ath/ath9k/htc_hst.c index 4a9570d..a304748 100644 --- a/drivers/net/wireless/ath/ath9k/htc_hst.c +++ b/drivers/net/wireless/ath/ath9k/htc_hst.c@@ -278,10 +278,12 @@ int htc_connect_service(struct htc_target *target, if (!time_left) { dev_err(target->dev, "Service connection timeout for: %d\n", service_connreq->service_id); - return -ETIMEDOUT; + ret = -ETIMEDOUT; + goto err; } *conn_rsp_epid = target->conn_rsp_epid; + kfree_skb(skb); return 0; err: kfree_skb(skb);
The allocated skb should be freed in the TX completion hander, ath9k_htc_txcompletion_cb() - doing it in htc_connect_service() is wrong, I think. Sujith