Re: [PATCH 04/11] brcmsmac: radio on led support

On 12/05/2012 04:09 PM, Hauke Mehrtens wrote:

quoted

+	if (state)

quoted

+		bcma_cc_set32(cc_drv, BCMA_CC_GPIOOUT, gpio_out);
+	else
+		bcma_cc_mask32(cc_drv, BCMA_CC_GPIOOUT, ~gpio_out);

Could you use bcma_chipco_gpio_out() instead, in the mips tree is a
patch adding locking around the gpio registers. bcma_cc_set32 and
bcma_cc_mask32 are not atomic. Two threads are accessing them in
parallel will cause problems. The patches in the mips tree are adding
full libgpio support, so it should also be possible to register the gpio
from the generic gpio system and use the generic gpio functions.

Sure. I will rework the patch.

Gr. AvS