Thread (38 messages) 38 messages, 3 authors, 2012-11-28

Re: [RFC 03/14] {cfg,nl}80211: set and get default mesh power mode

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2012-11-17 08:58:32

On Fri, 2012-11-16 at 22:47 -0800, Marco Porsch wrote:
Possibilities of setting and getting mesh default power mode are
added.
ditto.

+ * @NL80211_MESHCONF_POWER_MODE: default link-specific power save
mode
please describe the type of the attribute (u8)

+       FILL_IN_MESH_PARAM_IF_SET(tb, cfg, power_mode,
+                                 mask, NL80211_MESHCONF_POWER_MODE,
+                                 nla_get_u8);
Huh, ok, how did this FILL_IN_MESH_PARAM thing ever get here ... sad I
missed that, all of those are *completely* missing range checks.

Please add them here, and somebody should also follow up with a patch to
fix them on the other attributes.

johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help