Thread (10 messages) 10 messages, 4 authors, 2012-11-21

Re: [PATCH v8 4/4] dynamic_debug: dynamic hex dump

From: Joe Perches <joe@perches.com>
Date: 2012-11-15 17:32:04

On Thu, 2012-11-15 at 17:55 +0200, Andrei Emeltchenko wrote:
Hi Vladimir,

On Thu, Nov 15, 2012 at 1:17 PM, Vladimir Kondratiev
[off-list ref] wrote:
quoted
Introduce print_hex_dump_debug() that can be dynamically controlled, similar to
pr_debug.
You could just use "%*ph" specifier in pr_debug
Possibly true, but %*ph doesn't emit ascii nor
does it format a large block of data very well.

Maybe use of
	pr_debug("%*ph", len, buf)
vs
	print_hex_dump_bytes("prefix", DUMP_PREFIX_<STYLE>, buf, len)

could be described a bit in dynamic_debug_howto
or perhaps all of the various printk, dev_<level>,
<subsystem>_<level> styles and all the various
debugging options would be better described in a
new printk_howto
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help