re: ath6kl: move ath6kl_wmi_startscan_cmd()
From: Dan Carpenter <hidden>
Date: 2012-11-27 07:25:40
Hello Kalle Valo,
The patch c8c72b74e289: "ath6kl: move ath6kl_wmi_startscan_cmd()"
from Jul 19, 2012, leads to the following warning:
drivers/net/wireless/ath/ath6kl/wmi.c:2016 ath6kl_wmi_beginscan_cmd()
error: buffer overflow 'sc->supp_rates' 2 <= 2
drivers/net/wireless/ath/ath6kl/wmi.c
2009 for (band = 0; band < IEEE80211_NUM_BANDS; band++) {
^^^^^^^^^^^^^^^^^^^
This is 3.
2010 sband = ar->wiphy->bands[band];
2011
2012 if (!sband)
2013 continue;
2014
2015 ratemask = rates[band];
2016 supp_rates = sc->supp_rates[band].rates;
->supp_rates has only ATH6KL_NUM_BANDS (2) elements so we are reading
one element beyond the end.
2017 num_rates = 0;
regards,
dan carpenter