Thread (4 messages) 4 messages, 2 authors, 2012-10-10

Re: [PATCH V3] ath/ath9k/ar9003_eeprom.c: Remove semicolon after if

From: Joe Perches <joe@perches.com>
Date: 2012-10-10 18:22:11
Also in: kernel-janitors, lkml, netdev

On Wed, 2012-10-10 at 18:38 +0200, Peter Senna Tschudin wrote:
This patch remove a semicolon after if(...) that is preventing the
error check to work correctly. Removing this semicolon will change the
code behavior, but this is intended.

The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r1@
position p;
@@
if (...);@p
this semantic patch would be a lot less tedious to
inspect the results if it excluded else after the
semicolon.

I've used perl for more or less the same output.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help