Re: [PATCH] rtlwifi: use %*ph[C] to dump small buffers
From: Larry Finger <hidden>
Date: 2012-09-27 15:16:59
Also in:
netdev
Possibly related (same subject, not in this thread)
- 2012-09-28 · Re: [PATCH] rtlwifi: use %*ph[C] to dump small buffers · Joe Perches <joe@perches.com>
- 2012-09-28 · Re: [PATCH] rtlwifi: use %*ph[C] to dump small buffers · Larry Finger <hidden>
- 2012-09-28 · RE: [PATCH] rtlwifi: use %*ph[C] to dump small buffers · David Laight <hidden>
- 2012-09-28 · Re: [PATCH] rtlwifi: use %*ph[C] to dump small buffers · Joe Perches <hidden>
- 2012-09-27 · Re: [PATCH] rtlwifi: use %*ph[C] to dump small buffers · Larry Finger <hidden>
On 09/26/2012 11:45 AM, Joe Perches wrote:
rate_mask uses: u32 ratr_bitmap = (u32) mac->basic_rates; ... u8 rate_mask[5]; ... [sets ratr_bitmap as u32] ... *(u32 *)&rate_mask = ((ratr_bitmap & 0x0fffffff) | ratr_index << 28); ... rtl92c_fill_h2c_cmd(hw, H2C_RA_MASK, 5, rate_mask); Looks like a possible endian misuse to me.
Joe, I had to track the flow through two more routines, but I think your analysis is correct. The only BE platform I have does not have any PCIe hardware, thus I can only test the USB version. It does not show a major problem, but this one with the rate masks would be subtle. Thanks, Larry