Re: [PATCH] vt6656: [BUG] - Failed connection, incorrect endian. v2

On Wed, 2012-08-29 at 16:20 -0500, Larry Finger wrote:

On 08/29/2012 03:54 PM, Malcolm Priestley wrote:

quoted

This patch fixes a bug with driver failing to negotiate a connection.

The bug was traced to commit
203e4615ee9d9fa8d3506b9d0ef30095e4d5bc90
staging: vt6656: removed custom definitions of Ethernet packet types

In that patch, definitions in include/linux/if_ether.h replaced ones
in tether.h which had both big and little endian definitions.

include/linux/if_ether.h only refers to big endian values, cpu_to_be16
should be used for the correct endian architectures.

checkpatch fixed version.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>

Patches for staging drivers should be sent to gregkh@linuxfoundation.org. He is 
the one that handles them. In addition, the patch subject line usually has the 
sequence "staging: vt6656: blabla" the way the faulty patch did.

Thanks

I have forwarded the patch.


Regards


Malcolm